Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fixes nose cone bluffness issue #610 #611

Merged
merged 2 commits into from
May 25, 2024

Conversation

Lucas-Prates
Copy link
Contributor

@Lucas-Prates Lucas-Prates commented May 24, 2024

Pull request type

Bug fix issue #610 .

  • Code changes (bugfix, features)

Checklist

  • Lint (black rocketpy/ tests/) has passed locally

Current behavior

The find_radius method inside the NoseCone class computes the square of its argument x. The lambda function, however, passes a list to it, causing a TypeError.

New behavior

Just pass the value instead of the list.

Breaking change

  • No

@Lucas-Prates Lucas-Prates requested a review from a team as a code owner May 24, 2024 01:16
@Lucas-Prates Lucas-Prates added the Bug Something isn't working label May 24, 2024
@Lucas-Prates
Copy link
Contributor Author

As suggested by @Gui-FernandesBR, this might be a good indication to expand unit tests for aero_surface classes. This seems like an error that would have been caught by tests.

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.56%. Comparing base (209434f) to head (836cde7).
Report is 1 commits behind head on develop.

Files Patch % Lines
rocketpy/rocket/aero_surface.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #611      +/-   ##
===========================================
- Coverage    73.60%   73.56%   -0.05%     
===========================================
  Files           70       70              
  Lines        10310    10313       +3     
===========================================
- Hits          7589     7587       -2     
- Misses        2721     2726       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR
Copy link
Member

As suggested by @Gui-FernandesBR, this might be a good indication to expand unit tests for aero_surface classes. This seems like an error that would have been caught by tests.

Don't worry, we can add more robust tests for aero_surfaces classes in the future.
I think @lucasfourier should be aware of this.

Thank you for your fast solution, @Lucas-Prates !! Nice job, we are merging this one.

@Gui-FernandesBR Gui-FernandesBR merged commit 92fb685 into develop May 25, 2024
8 of 10 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the fix/nosecone_bluffness_#610 branch May 25, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

BUG: TypeError when creating nose cones with bluffness between 0 and 1
3 participants